Added support for additional Tomcat access log configuration properties #16039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rties checkExists, conditionIf, conditionUnless, encoding, ipv6Canonical, locale
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
This is great, thank you. Was there a reason for not adding a property for |
wilkinsona
changed the title
Contributor
Author
|
No worries. The |
Member
|
So it was. Sorry. I’ve edited my comment on #16035 to hopefully avoid further confusion. |
wilkinsona
added
type: enhancement
snicoll
approved these changes
Mar 29, 2019
| * Set the locale used to format timestamps in log entries and in log file | ||
| * name suffix. | ||
| */ | ||
| private String locale = Locale.getDefault().toString(); |
Member
There was a problem hiding this comment.
We can't really do that as the sole purpose of the field init is to express a default value that isn't dependant of the environment. I'll remove that as part of the polish.
snicoll
pushed a commit
that referenced
this pull request
Mar 29, 2019
snicoll
added a commit
that referenced
this pull request
Mar 29, 2019
* pr/16039: Polish "Complete support for customizing Tomcat's access log" Complete support for customizing Tomcat's access log
Member
|
@amcghie thank you very much for making your first contribution to Spring Boot. This is now merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the following additional Tomcat Access Log configuration properties:
server.tomcat.accessLog.checkExistsserver.tomcat.accessLog.conditionIfserver.tomcat.accessLog.conditionUnlessserver.tomcat.accessLog.encodingserver.tomcat.accessLog.ipv6Canonicalserver.tomcat.accessLog.localeProposed solution for #16035